Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5132#discussion_r159779494
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/StreamTableEnvironmentValidationTest.scala
 ---
    @@ -30,77 +30,88 @@ import org.junit.Test
     
     class StreamTableEnvironmentValidationTest extends TableTestBase {
     
    +  // 
----------------------------------------------------------------------------------------------
    +  // schema definition by position
    +  // 
----------------------------------------------------------------------------------------------
    +
    +  @Test(expected = classOf[TableException])
    +  def testInvalidProctimeAttributesByPosition(): Unit = {
    +    val util = streamTestUtil()
    +    // table definition makes no sense
    +    util.addTable[(Long, Int, String, Int, Long)]('a.rowtime.rowtime, 'b, 
'c, 'd, 'e)
    --- End diff --
    
    method name suggests a test about proctime but only rowtime is used.


---

Reply via email to