[ https://issues.apache.org/jira/browse/FLINK-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312787#comment-16312787 ]
ASF GitHub Bot commented on FLINK-8366: --------------------------------------- GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/5244 [FLINK-8366] [table] Use Row instead of String as key when process upsert results ## What is the purpose of the change This pr fix the bug in `TableSinkITCase.upsertResults()`. In `upsertResults()` function, we use String as key to upsert results. This will make (1,11) and (11,1) have the same key (i.e., 111). ## Brief change log - Use Row instead of String to avoid the String problem. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hequn8128/flink 8366 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5244.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5244 ---- commit 259751257a5b4154d4b16b46c7fa38e25638a5ef Author: 军长 <hequn.chq@...> Date: 2018-01-05T08:53:31Z [FLINK-8366] [table] Use Row instead of String as key when process upsert results ---- > Use Row instead of String as key when process upsert results > ------------------------------------------------------------ > > Key: FLINK-8366 > URL: https://issues.apache.org/jira/browse/FLINK-8366 > Project: Flink > Issue Type: Bug > Components: Table API & SQL > Reporter: Hequn Cheng > Assignee: Hequn Cheng > > In {{TableSinkITCase.upsertResults()}} function, we use String as key to > upsert results. This will make (1,11) and (11,1) have the same key (i.e., > 111). > This bugfix use Row instead of String to avoid the String problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)