[
https://issues.apache.org/jira/browse/FLINK-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313053#comment-16313053
]
ASF GitHub Bot commented on FLINK-8340:
---------------------------------------
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5226
This PR is based on #5225
> Do not pass Configuration and configuration directory to CustomCommandLine
> methods
> ----------------------------------------------------------------------------------
>
> Key: FLINK-8340
> URL: https://issues.apache.org/jira/browse/FLINK-8340
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Currently, all methods in {{CustomCommandLine}} need a {{Configuration}} and
> sometimes the configuration directory. Since these values should not change
> over the lifetime of the {{CustomCommandLine}} we should pass them as a
> constructor argument instead of a method argument.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
