[
https://issues.apache.org/jira/browse/FLINK-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313125#comment-16313125
]
ASF GitHub Bot commented on FLINK-8362:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5243
I vaguely recall that there was a reason why we did not shade the
Elasticsearch connectors initially. Maybe a license issue. @zentol and
@tzulitai can you chime in here?
If we want to go ahead with this, few comments:
- Not sure we should relocate the Flink elasticsearch code. Why is that
needed?
- Would be good to add for each dependency that is shaded should have a
comment about the license. Some licenses are not compatible with shading.
- Some licenses may need an additional license file or a mention in an
extra bundled NOTICE file, see the `flink-s3-fs-presto`
- In general, we cannot suppress all forwarded files from `META-INF` for
dependencies, especiallylicense related files.
> Shade Elasticsearch dependencies away
> -------------------------------------
>
> Key: FLINK-8362
> URL: https://issues.apache.org/jira/browse/FLINK-8362
> Project: Flink
> Issue Type: Improvement
> Components: Build System, ElasticSearch Connector
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> It would be nice to make the Elasticsearch connectors self-contained just
> like the s3 file system implementations and the cassandra connector.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
