Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5205#discussion_r159899525
--- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java ---
@@ -186,7 +186,7 @@ private static long byteArrayToLong(byte[] ba, int
offset) {
long l = 0;
for (int i = 0; i < SIZE_OF_LONG; ++i) {
- l |= (ba[offset + SIZE_OF_LONG - 1 - i] & 0xffL) << (i
<< 3);
+ l |= (ba[offset + SIZE_OF_LONG - 1 - i] & 0xffL) <<
((long) i << 3);
--- End diff --
I think this might be not quite right - the number of bits to shift stays
below 64 and should be correct as an int.
---
