[ 
https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315220#comment-16315220
 ] 

ASF GitHub Bot commented on FLINK-8302:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5202#discussion_r160047888
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
 ---
    @@ -1216,6 +1216,64 @@ class ScalarFunctionsTest extends 
ScalarTypesTestBase {
         )
       }
     
    +  @Test
    +  def testShiftLeft(): Unit = {
    +    testSqlApi(
    +      "SHIFT_LEFT(1,1)",
    +      "2"
    +    )
    +
    +    testSqlApi(
    +      "SHIFT_LEFT(21,1)",
    +      "42"
    +    )
    +
    +    testSqlApi(
    +      "SHIFT_LEFT(2147483647,-2147483648)",
    +      "2147483647"
    +    )
    +
    +    testSqlApi(
    +      "SHIFT_LEFT(-2147483648,2147483647)",
    +      "0"
    +    )
    +
    +    testSqlApi(
    +      "SHIFT_LEFT(9223372036854775807,-2147483648)",
    +      "9223372036854775807"
    +    )
    +  }
    +
    +  @Test
    +  def testShiftRight(): Unit = {
    --- End diff --
    
    Add a test case using column defined in `ScalarTypesTestBase  `, just like 
as follow:  
    ```
    testSqlApi(
          "SHIFT_RIGHT(f4,1)", // f4 is BIGINT type
          "22"
        )
    ```


> Support shift_left and shift_right in TableAPI
> ----------------------------------------------
>
>                 Key: FLINK-8302
>                 URL: https://issues.apache.org/jira/browse/FLINK-8302
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: DuBin
>              Labels: features
>             Fix For: 1.5.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Add shift_left and shift_right support in TableAPI, shift_left(input, n) act 
> as input << n, shift_right(input, n) act as input >> n.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to