Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4552#discussion_r157760560
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandler.java
---
@@ -158,32 +164,44 @@ public void exceptionCaught(ChannelHandlerContext
ctx, Throwable cause) throws E
@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws
Exception {
try {
- if (!bufferListener.hasStagedBufferOrEvent() &&
stagedMessages.isEmpty()) {
- decodeMsg(msg, false);
- }
- else {
- stagedMessages.add(msg);
- }
- }
- catch (Throwable t) {
+ decodeMsg(msg);
+ } catch (Throwable t) {
notifyAllChannelsOfErrorAndClose(t);
}
}
+ @Override
+ public void userEventTriggered(ChannelHandlerContext ctx, Object msg)
throws Exception {
+ if (msg instanceof RemoteInputChannel) {
+ boolean triggerWrite =
inputChannelsWithCredit.isEmpty();
--- End diff --
please re-add the comment here, too
---
