[
https://issues.apache.org/jira/browse/FLINK-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316078#comment-16316078
]
ASF GitHub Bot commented on FLINK-8341:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5227#discussion_r160113577
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
@@ -281,16 +287,22 @@ object FlinkShell {
"-m", "yarn-cluster"
)
- val options = CliFrontendParser.parseRunCommand(args.toArray)
+ val commandLine = CliFrontendParser.parse(
+ CliFrontendParser.getRunCommandOptions,
+ args.toArray,
+ true)
+
+ val options = new RunOptions(commandLine)
+
val frontend = new CliFrontend(
configuration,
CliFrontend.loadCustomCommandLines(configuration,
configurationDirectory))
val config = frontend.getConfiguration
--- End diff --
Unused variable `config`.
> Remove unneeded CommandLineOptions
> ----------------------------------
>
> Key: FLINK-8341
> URL: https://issues.apache.org/jira/browse/FLINK-8341
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> With the refactorings of the {{CliFrontend}} we no longer have to keep the
> JobManager address and commandLine in the {{CommandLineOptions}}. Therefore,
> these fields should be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
