[GitHub] flink pull request #5229: [FLINK-8343] [flip6] Remove Yarn specific commands...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5229#discussion_r160139085
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ---
    @@ -393,6 +395,23 @@ public YarnClusterClient 
deployJobCluster(ClusterSpecification clusterSpecificat
                }
        }
     
    +   @Override
    +   public void terminateCluster(String clusterId) throws FlinkException {
    --- End diff --
    
    Code duplication. Should be:
    ```
    @Override
    public void terminateCluster(String clusterId) throws FlinkException {
        terminateCluster(ConverterUtils.toApplicationId(clusterId));
    }
    ```
      


---