[ 
https://issues.apache.org/jira/browse/FLINK-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316432#comment-16316432
 ] 

ASF GitHub Bot commented on FLINK-8343:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5229#discussion_r160139085
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ---
    @@ -393,6 +395,23 @@ public YarnClusterClient 
deployJobCluster(ClusterSpecification clusterSpecificat
                }
        }
     
    +   @Override
    +   public void terminateCluster(String clusterId) throws FlinkException {
    --- End diff --
    
    Code duplication. Should be:
    ```
    @Override
    public void terminateCluster(String clusterId) throws FlinkException {
        terminateCluster(ConverterUtils.toApplicationId(clusterId));
    }
    ```
      


> Add support for job cluster deployment
> --------------------------------------
>
>                 Key: FLINK-8343
>                 URL: https://issues.apache.org/jira/browse/FLINK-8343
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> For Flip-6 we have to enable a different job cluster deployment. The 
> difference is that we directly submit the job when we deploy the Flink 
> cluster instead of following a two step approach (first deployment and then 
> submission).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to