[
https://issues.apache.org/jira/browse/FLINK-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316516#comment-16316516
]
ASF GitHub Bot commented on FLINK-8371:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5261#discussion_r160178046
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -52,6 +55,10 @@
/** Flag indicating whether the subpartition has been released. */
private volatile boolean isReleased;
+ /** The number of non-event buffers currently in this subpartition */
--- End diff --
nit: Should also end with a period.
> Buffers are not recycled in a non-spilled SpillableSubpartition upon release
> ----------------------------------------------------------------------------
>
> Key: FLINK-8371
> URL: https://issues.apache.org/jira/browse/FLINK-8371
> Project: Flink
> Issue Type: Bug
> Components: Network
> Affects Versions: 1.2.0, 1.3.0, 1.2.1, 1.3.1, 1.4.0, 1.3.2
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Blocker
>
> {{SpillableSubpartition}} only recycles buffers in its {{buffer}} queue if
> there is no view attached to it yet. If there is a view, it delegates this
> task to the view, but {{SpillableSubpartitionView}} only instructs the
> {{SpilledSubpartitionView}} to clean up in its {{releaseAllResources()}}.
> Similarly to the {{PipelinesSubpartition}} implementation, we should always
> clean up and recycle the buffers in {{SpillableSubpartition#release()}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
