[
https://issues.apache.org/jira/browse/FLINK-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316672#comment-16316672
]
ASF GitHub Bot commented on FLINK-8389:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5265
[FLINK-8389] [flip6] Release all slots upon closing of JobManager
connection
## What is the purpose of the change
Release the slots assigned to a `JobMaster` once it disconnects from the
`TaskExecutor`.
## Brief change log
- Upon receiving a disconnect call from the `JobMaster`, the `TaskExecutor`
tries to free all slots
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink releaseSlots
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5265
----
commit 406c75deadd61254bdc429c0d7be44cac4a18353
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-08T14:09:32Z
[FLINK-7903] [tests] Add flip6 build profile
The flip6 build profile only runs the Flip-6 related test cases. Moreover,
all Flip-6 related test cases are excluded when not running the flip6 build
profile. This should reduce testing time when adding more and more Flip-6
test cases.
Include flink-test-utils-junit in all submodules to make the Category
marker interfaces Flip6 and OldAndFlip6 available
This closes #4889.
commit 7026c6bcbd5ab81503c3a3e99cad525c501b2514
Author: Till Rohrmann <trohrmann@...>
Date: 2017-10-24T13:51:27Z
[hotfix] Remove unnecessary surefire plugin version in
flink-connector-elasticsearch5
commit 8a38685573f97dc3f1bb8255cbf9614c7e0373ad
Author: Till Rohrmann <trohrmann@...>
Date: 2017-10-23T14:24:58Z
[FLINK-7904] Enable Flip6 build profile on Travis
This adds a new Travis build matrix entry which runs the Flip-6 build
profile
Reuse caches and split core+test into core and tests Travis build
This closes #4890.
commit e61aea3c97ac1e6513882e38f3eb4b3459bd8c1d
Author: Till Rohrmann <trohrmann@...>
Date: 2017-10-24T09:32:05Z
[FLINK-7909] Unify Flink test bases
Introduce a MiniClusterResource which is used by the AbstractTestBase to
start
and shut down a FlinkMiniCluster. Additionally, this resource registers the
proper
Stream- and ExecutionEnvironment which is now the only way for tests to
start
jobs. This change will thus allow to centrally control which FlinkCluster
will
be started for all test bases.
commit 908e00f2d483f46e486b6c3f944d649ae25dbcd8
Author: Till Rohrmann <trohrmann@...>
Date: 2017-10-24T14:20:15Z
[FLINK-7909] Replace StreamingMultipleProgramsTestBase by AbstractTestBase
The AbstractTestBase fully subsumes the functionality of the
StreamingMultipleProgramsTestBase since it now is the most general test base
for streaming and batch jobs. As a consequence, we can safely remove the
StreamingMultipleProgramsTestBase and let all corresponding tests extend
from
AbstractTestBase.
This closes #4896.
commit f0bba2eb94983b4fea3a765d2195b57c75de7183
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-08T15:33:51Z
[hotfix] Remove unnecessary exception catching in StreamingProgramTestBase
commit e2c0ef5fca244bccc97d3052011053ec115bd00b
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-08T17:23:27Z
[FLINK-7910] [tests] Generalize Test(Stream)Environment to use JobExecutor
This commit introduces the JobExecutor interface which abstracts the actual
mini cluster
from the Test(Stream)Environment. By letting the Flip-6 MiniCluster as well
as the
FlinkMiniCluster implement this interface, we can run all test base jobs
either on the
Flip-6 mini cluster or on the current mini cluster.
This closes #4897.
commit ceabdfe5f806c9a9c1cd7dab5f25cf87f45619cc
Author: Till Rohrmann <trohrmann@...>
Date: 2017-12-01T14:02:09Z
[FLINK-8389] [flip6] Release all slots upon closing of JobManager connection
commit 59df741fb092e87e887fd56fab520875e374d283
Author: Till Rohrmann <trohrmann@...>
Date: 2017-12-01T14:10:46Z
[hotfix] Enable checkpointing RPC calls
----
> Release all slots upon closing of JobMaster connection
> ------------------------------------------------------
>
> Key: FLINK-8389
> URL: https://issues.apache.org/jira/browse/FLINK-8389
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{TaskExecutor}} should release all slots when the {{JobMaster}}
> disconnects from it (active disconnect instead of heartbeat timeout
> initiated). This will make the slots faster available again.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
