[
https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317231#comment-16317231
]
ASF GitHub Bot commented on FLINK-8325:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160268601
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1130,259 +1134,263 @@ object AggregateUtil {
// create aggregate function instances by function type and aggregate
field data type.
aggregateCalls.zipWithIndex.foreach { case (aggregateCall, index) =>
val argList: util.List[Integer] = aggregateCall.getArgList
- if (argList.isEmpty) {
- if
(aggregateCall.getAggregation.isInstanceOf[SqlCountAggFunction]) {
- aggFieldIndexes(index) = Array[Int](0)
- } else {
- throw new TableException("Aggregate fields should not be empty.")
+
+ if (aggregateCall.getAggregation.isInstanceOf[SqlCountAggFunction]) {
+ aggregates(index) = new CountAggFunction()
+ if(argList.isEmpty) {
+ aggFieldIndexes(index) = Array[Int](-1)
+ }else{
--- End diff --
add spaces
> Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)
> ------------------------------------------------------------------
>
> Key: FLINK-8325
> URL: https://issues.apache.org/jira/browse/FLINK-8325
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.5.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> COUNT(1) with Group Window, always output 0.
> e.g.
> DATA:
> {code}
> val data = List(
> (1L, 1, "Hi"),
> (2L, 2, "Hello"),
> (4L, 2, "Hello"),
> (8L, 3, "Hello world"),
> (16L, 3, "Hello world"))
> {code}
> SQL:
> {code}
> SELECT b, COUNT(1) FROM MyTable GROUP BY Hop(proctime, interval '0.001'
> SECOND, interval '0.002' SECOND),b
> {code}
> OUTPUT:
> {code}
> 1,0,1,
> 1,0,1,
> 2,0,1,
> 2,0,1,
> 2,0,2,
> 3,0,1,
> 3,0,1
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
