[GitHub] flink pull request #5186: [FLINK-8288] [runtime] register job master rest en...

[NicoK]

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5186#discussion_r160368484
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/JobClusterEntrypoint.java
 ---
    @@ -132,6 +122,16 @@ protected void startClusterComponents(
                LOG.debug("Starting JobMaster REST endpoint.");
                jobMasterRestEndpoint.start();
     
    +           resourceManager = createResourceManager(
    +                           configuration,
    +                           ResourceID.generate(),
    +                           rpcService,
    +                           highAvailabilityServices,
    +                           heartbeatServices,
    +                           metricRegistry,
    +                           this,
    +                           jobMasterRestEndpoint.getRestAddress());
    +
    --- End diff --
    
    the indentation is a bit off (one tab to many) compared to the surrounding 
code


---