[
https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318538#comment-16318538
]
ASF GitHub Bot commented on FLINK-8325:
---------------------------------------
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160426130
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala
---
@@ -254,7 +254,7 @@ class JoinITCase(
val table =
CollectionDataSets.getSmall3TupleDataSet(env).toTable(tEnv).as('a1, 'a2, 'a3)
tEnv.registerTable("A", table)
- val sqlQuery2 = "SELECT * FROM (SELECT count(*) FROM A) CROSS JOIN A"
--- End diff --
HI, @fhueske I do not think The PR breaks the correctness of the test :),
because when we run this test case will match
`DataSetAggregateWithNullValuesRule`. which will union a NULL row to dataset.
so using `COUNT(a1)` result `3` and using `COUNT(*)` result `4`. I think this
is batch bug. The snip as follow:
I think we can talk about this bug in FlINK-8355... What do you think?
> Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)
> ------------------------------------------------------------------
>
> Key: FLINK-8325
> URL: https://issues.apache.org/jira/browse/FLINK-8325
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.5.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> COUNT(1) with Group Window, always output 0.
> e.g.
> DATA:
> {code}
> val data = List(
> (1L, 1, "Hi"),
> (2L, 2, "Hello"),
> (4L, 2, "Hello"),
> (8L, 3, "Hello world"),
> (16L, 3, "Hello world"))
> {code}
> SQL:
> {code}
> SELECT b, COUNT(1) FROM MyTable GROUP BY Hop(proctime, interval '0.001'
> SECOND, interval '0.002' SECOND),b
> {code}
> OUTPUT:
> {code}
> 1,0,1,
> 1,0,1,
> 2,0,1,
> 2,0,1,
> 2,0,2,
> 3,0,1,
> 3,0,1
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
