Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5243#discussion_r160618041
  
    --- Diff: flink-connectors/flink-connector-elasticsearch/pom.xml ---
    @@ -93,6 +93,106 @@ under the License.
                                        
<rerunFailingTestsCount>3</rerunFailingTestsCount>
                                </configuration>
                        </plugin>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-shade-plugin</artifactId>
    +                           <executions>
    +                                   <execution>
    +                                           <id>shade-flink</id>
    +                                           <phase>package</phase>
    +                                           <goals>
    +                                                   <goal>shade</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   
<shadeTestJar>false</shadeTestJar>
    +                                                   <artifactSet>
    +                                                           <includes>
    +                                                                   
<include>*:*</include>
    +                                                           </includes>
    +                                                   </artifactSet>
    +                                                   <relocations>
    +                                                           <!-- 
elasticsearch 1.x already shades this but forgets the service file -->
    +                                                           <relocation>
    +                                                                   
<pattern>com.fasterxml.jackson</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.streaming.connectors.elasticsearch.shaded.org.elasticsearch.common.jackson</shadedPattern>
    +                                                           </relocation>
    +                                                           <relocation>
    +                                                                   
<pattern>com.spatial4j</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.streaming.connectors.elasticsearch.shaded.com.spatial4j</shadedPattern>
    +                                                           </relocation>
    +
    +                                                           <!-- relocate 
everything from the flink-connector-elasticsearch base project -->
    --- End diff --
    
    Not sure if this is necessary. @NicoK can you comment on this?


---

Reply via email to