[ https://issues.apache.org/jira/browse/FLINK-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323208#comment-16323208 ]
ASF GitHub Bot commented on FLINK-8296: --------------------------------------- Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5188 Thanks! Merging this ... > Rework FlinkKafkaConsumerBestTest to not use Java reflection for dependency > injection > ------------------------------------------------------------------------------------- > > Key: FLINK-8296 > URL: https://issues.apache.org/jira/browse/FLINK-8296 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector, Tests > Reporter: Tzu-Li (Gordon) Tai > Assignee: Tzu-Li (Gordon) Tai > Fix For: 1.5.0, 1.4.1 > > > The current {{FlinkKafkaConsumerBaseTest}} is heavily relying on Java > reflection for dependency injection. Using reflection to compose unit tests > really should be a last resort, and indicates that the tests there are highly > implementation-specific, and that we should make the design more testable. -- This message was sent by Atlassian JIRA (v6.4.14#64029)