[
https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323676#comment-16323676
]
ASF GitHub Bot commented on FLINK-8306:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5284#discussion_r161159244
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java
---
@@ -265,10 +274,8 @@ public void
testSnapshotStateWithCommitOnCheckpointsEnabled() throws Exception {
//
--------------------------------------------------------------------
- final OneShotLatch runLatch = new OneShotLatch();
- final OneShotLatch stopLatch = new OneShotLatch();
- final AbstractFetcher<String, ?> fetcher =
getRunnableMockFetcher(runLatch, stopLatch);
- when(fetcher.snapshotCurrentState()).thenReturn(state1, state2,
state3);
+ final MockFetcher<String> fetcher = spy(new MockFetcher<>());
+
doReturn(state1).doReturn(state2).doReturn(state3).when(fetcher).snapshotCurrentState();
--- End diff --
Maybe we could go one small step further?
```
private static class MockFetcher<T> ... {
private final ArrayDeque<HashMap<KafkaTopicPartition, Long>>
stateSnapshotsToReturn = new ArrayDeque<>();
public MockFetcher(HashMap<KafkaTopicPartition, Long>..
stateSnapshotsToReturn) {
this.stateSnapshotsToReturn.addAll(Arrays.asList(stateSnapshotsToReturn));
}
@Override
public HashMap<KafkaTopicPartition, Long> snapshotCurrentState() {
checkState(!stateSnapshotsToReturn.isEmpty());
return stateSnapshotsToReturn.poll();
}
}
```
> FlinkKafkaConsumerBaseTest has invalid mocks on final methods
> -------------------------------------------------------------
>
> Key: FLINK-8306
> URL: https://issues.apache.org/jira/browse/FLINK-8306
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector, Tests
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Critical
> Fix For: 1.5.0, 1.4.1
>
>
> The {{FlinkKafkaConsumerBaseTest}} has invalid mocks on a final
> {{AbstractFetcher::commitInternalOffsetsToKafka(...)}} method. While an easy
> fix would be to simply make that method non-final, that is not ideal since it
> would be best that the method is left final to prevent overrides in
> subclasses.
> This suggests that offset committing functionality is too tightly coupled
> with the {{AbstractFetcher}}, making it hard to perform concise tests to
> verify offset committing.
> I suggest that we decouple record fetching and offset committing as separate
> services behind different interfaces. We should introduce a new interface,
> say {{KafkaOffsetCommitter}}, and test against that instead. Initially, we
> can simply let {{AbstractFetcher}} implement {{KafkaOffsetCommitter}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
