[ 
https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324118#comment-16324118
 ] 

ASF GitHub Bot commented on FLINK-8399:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5271#discussion_r161249685
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
 ---
    @@ -58,6 +58,27 @@
                .defaultValue(600)
                .withDeprecatedKeys("yarn.heap-cutoff-min");
     
    +   /**
    +    * The timeout for requesting slot to a task manager, in milliseconds.
    +    */
    +   public static final ConfigOption<Integer> TASK_MANAGER_REQUEST_TIMEOUT 
= ConfigOptions
    +                   .key("slotmanager.taskmanager.request-timeout")
    +                   .defaultValue(30000);
    +
    +   /**
    +    * The timeout for a slot request to be discarded, in milliseconds.
    +    */
    +   public static final ConfigOption<Integer> SLOT_REQUEST_TIMEOUT = 
ConfigOptions
    +                   .key("slotmanager.slot.request-timeout")
    +                   .defaultValue(600000);
    +
    +   /**
    +    * The timeout for an idle task manager to be released, in milliseconds.
    +    */
    +   public static final ConfigOption<Integer> TASK_MANAGER_TIMEOUT = 
ConfigOptions
    +                   .key("slotmanager.taskmanager.timeout")
    --- End diff --
    
    maybe `slotmanager.taskmanager-timeout`


> Use independent configurations for the different timeouts in slot manager
> -------------------------------------------------------------------------
>
>                 Key: FLINK-8399
>                 URL: https://issues.apache.org/jira/browse/FLINK-8399
>             Project: Flink
>          Issue Type: Bug
>          Components: Cluster Management
>    Affects Versions: 1.5.0
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> There are three parameter in slot manager to indicate the timeout for slot 
> request to task manager, slot request to be discarded and task manager to be 
> released. But now they all come from the value of AkkaOptions.ASK_TIMEOUT, 
> need to use independent configurations for them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to