[ 
https://issues.apache.org/jira/browse/FLINK-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324528#comment-16324528
 ] 

ASF GitHub Bot commented on FLINK-8422:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/5292

    [FLINK-8422] [core] Checkstyle for org.apache.flink.api.java.tuple

    ## What is the purpose of the change
    
    Update TupleGenerator for Flink's checkstyle and rebuild Tuple and 
TupleBuilder classes.
    
    ## Brief change log
    
    `TupleGenerator` has been updated to write Flink-checkstyle compliant code.
    
    The following non-generated files were manually updated: `Tuple`, `Tuple0`, 
`Tuple0Builder`, `Tuple2Test`
    
    `org.apache.flink.api.java.tuple` was removed from the checkstyle 
suppressions for `flink-core`.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage. 
Re-running `TupleGenerator` should replicate the newly updated files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 
8422_checkstyle_for_org_apache_flink_api_java_tuple

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5292
    
----
commit b2fa893e20ed09b3898c64f6821f2d177369f0a7
Author: Greg Hogan <code@...>
Date:   2018-01-12T16:35:15Z

    [FLINK-8422] [core] Checkstyle for org.apache.flink.api.java.tuple
    
    Update TupleGenerator for Flink's checkstyle and rebuild Tuple and
    TupleBuilder classes.

----


> Checkstyle for org.apache.flink.api.java.tuple
> ----------------------------------------------
>
>                 Key: FLINK-8422
>                 URL: https://issues.apache.org/jira/browse/FLINK-8422
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.5.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Trivial
>
> Update {{TupleGenerator}} for Flink's checkstyle and rebuild {{Tuple}} and 
> {{TupleBuilder}} classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to