Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4552#discussion_r161485403
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -434,6 +443,29 @@ private RemoteInputChannel
createRemoteInputChannel(SingleInputGate inputGate) t
UnregisteredMetricGroups.createUnregisteredTaskMetricGroup().getIOMetricGroup());
}
+ /**
+ * Creates and returns a remote input channel for the specific input
gate with specific partition request client.
+ *
+ * @param inputGate The input gate owns the created input channel.
+ * @param client The client is used to send partition request.
+ * @return The new created remote input channel.
+ */
+ private RemoteInputChannel createRemoteInputChannel(SingleInputGate
inputGate, PartitionRequestClient client) throws Exception {
--- End diff --
could you modify
`PartitionRequestClientHandlerTest#createRemoteInputChannel(SingleInputGate)`
to rely on this method, i.e. `return createRemoteInputChannel(inputGate,
mock(PartitionRequestClient.class));`?
---
