[
https://issues.apache.org/jira/browse/FLINK-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326905#comment-16326905
]
ASF GitHub Bot commented on FLINK-7938:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5281#discussion_r161693211
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java
---
@@ -756,6 +756,11 @@ public boolean isClearCalled() {
public void update(List<T> values) throws Exception {
clear();
+ addAll(values);
+ }
+
+ @Override
+ public void addAll(List<T> values) throws Exception {
if (values != null && !values.isEmpty()) {
--- End diff --
I think the check for `!values.isEmpty()` is not required and just
boilerplate - the following line also works for empty lists.
> support addAll() in ListState
> -----------------------------
>
> Key: FLINK-7938
> URL: https://issues.apache.org/jira/browse/FLINK-7938
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Major
> Fix For: 1.5.0
>
>
> support {{addAll()}} in {{ListState}}, so Flink can be more efficient in
> adding elements to {{ListState}} in batch. This should give us a much better
> performance especially for {{ListState}} backed by RocksDB
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
