[ 
https://issues.apache.org/jira/browse/FLINK-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331899#comment-16331899
 ] 

ASF GitHub Bot commented on FLINK-8455:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5313#discussion_r162560352
  
    --- Diff: 
flink-core/src/test/java/org/apache/flink/configuration/ParentFirstPatternsTest.java
 ---
    @@ -0,0 +1,76 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.configuration;
    +
    +import org.junit.Test;
    +
    +import java.util.Arrays;
    +import java.util.HashSet;
    +
    +import static org.junit.Assert.assertTrue;
    +
    +/**
    + * Test that checks that all packages that need to be loaded 
'parent-first' are also
    + * in the parent-first patterns.
    + */
    +public class ParentFirstPatternsTest {
    --- End diff --
    
    will do


> Add Hadoop to the parent-first loading patterns
> -----------------------------------------------
>
>                 Key: FLINK-8455
>                 URL: https://issues.apache.org/jira/browse/FLINK-8455
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.4.0
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Blocker
>             Fix For: 1.5.0, 1.4.1
>
>
> Various users have reported issues (mainly in the BucketingSink) where they 
> get ClassCastExceptions related to Hadoop classes.
> In all cases, users had Hadoop dependencies bundled into their application 
> jar files. To make the experience better, I suggest to let Hadoop always load 
> its classes parent-first.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to