Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r162643699
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -829,7 +833,8 @@ object AggregateUtil {
outputType: RelDataType,
groupings: Array[Int]): (Option[DataSetPreAggFunction],
Option[TypeInformation[Row]],
- RichGroupReduceFunction[Row, Row]) = {
+ RichGroupReduceFunction[Row, Row],
+ Option[MapPartitionFunction[Row, Row]]) = {
--- End diff --
Please remove this parameter and extend `DataSetFinalAggFunction` to also
implement `RichMapPartitionFunction` such that it can be used as both (similar
to `DataSetPreAggFunction`).
---
