Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5318#discussion_r162865803
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -717,15 +717,14 @@ private void notifyOfNewResourceManagerLeader(String
newLeaderAddress, ResourceM
}
// drop the current connection or connection attempt
- if (resourceManagerConnection != null) {
- resourceManagerConnection.close();
- resourceManagerConnection = null;
- }
+ closeResourceManagerConnection(
+ new FlinkException("New ResourceManager leader
found under: " + newLeaderAddress +
+ '(' + newResourceManagerId + ')'));
}
// establish a connection to the new leader
if (newLeaderAddress != null) {
- log.info("Attempting to register at ResourceManager
{}", newLeaderAddress);
+ log.info("Attempting to register at ResourceManager
{}({})", newLeaderAddress, newResourceManagerId);
--- End diff --
nit: a space after the logged `newLeaderAddress` wouldn't hurt: `{} ({})`
---
