[
https://issues.apache.org/jira/browse/FLINK-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334381#comment-16334381
]
ASF GitHub Bot commented on FLINK-8471:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5334
[FLINK-8471] [flip6] Introduce configuration switch for Flip-6
## What is the purpose of the change
Add `mode` configuration parameter which enables and disables the Flip-6
code paths. Per default this is set to the old code path.
This PR is based on #5321.
## Brief change log
- Introduce `mode` configuration parameter with values `flip6` and `old`.
- Updated `config.md`
- Changed `CustomCommandLine` instantiation in `CliFrontend` to respect
`mode` configuration parameter
- Changed `YarnClusterDescriptor` instantiation in `FlinkYarnSessionCli` to
respect `mode` configuration parameter
- Adapted start-up scripts `start-cluster.sh`, `stop-cluster.sh`,
`taskmanager.sh` and `jobmanager.sh`
- Merged Flip-6 and old Mesos start-up scripts into one:
`mesos-appmaster-flip6-job.sh` -> `mesos-appmaster-job.sh`,
`mesos-appmaster-flip6-session.sh` -> `mesos-appmaster-session.sh` and
`mesos-taskmanager-flip6.sh` -> `mesos-taskmanager.sh`
## Verifying this change
This change is already covered by existing tests and I tested it manually.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink flip6ConfigurationSwitch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5334
----
commit aacf28506b855d515dc16a92edc814811ad050e5
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-19T21:18:35Z
[FLINK-8465] [flip6] Retrieve correct leader component address in
ClusterClient
Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo.
The
returned LeaderConnectionInfo contains the address of the leading cluster
component. In the old code this is the JobManager whereas in Flip-6 it is
the
Dispatcher.
commit e84e90e2ea25502408040461bf732ec27d6c526f
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-19T22:08:24Z
[FLINK-8471] [flip6] Introduce configuration switch for Flip-6
Add 'mode' configuration parameter which enables and disables the Flip-6
code paths. Per default this is set to the old code path.
commit 1f8007efcb6cec666554aafbfe2be9c232455e96
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-22T15:05:47Z
Merge Flip-6 and old Mesos start up scripts into one
----
> Add Flip-6 configuration switch
> -------------------------------
>
> Key: FLINK-8471
> URL: https://issues.apache.org/jira/browse/FLINK-8471
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> We should add a configuration switch to activate and de-activate the Flip-6
> code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
