[GitHub] flink pull request #5308: [FLINK-8449] [flip6] Extend OnCompletionActions to...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5308#discussion_r163540049
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ---
    @@ -1701,40 +1705,4 @@ void notifyExecutionChange(
                        }
                }
        }
    -
    -   @Override
    -   public ArchivedExecutionGraph archive() {
    --- End diff --
    
    Why is it better to move this logic to `ArchivedExecutionGraph`?


---