[ https://issues.apache.org/jira/browse/FLINK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337670#comment-16337670 ]
ASF GitHub Bot commented on FLINK-8449: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5308#discussion_r163540049 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -1701,40 +1705,4 @@ void notifyExecutionChange( } } } - - @Override - public ArchivedExecutionGraph archive() { --- End diff -- Why is it better to move this logic to `ArchivedExecutionGraph`? > Extend OnCompletionActions to receive AccessExecutionGraph > ---------------------------------------------------------- > > Key: FLINK-8449 > URL: https://issues.apache.org/jira/browse/FLINK-8449 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > The {{OnCompletionAction}} currently only receives the {{JobResult}} when the > job terminates. For further archiving of the {{ArchivedExecutionGraph}}, we > should change this to {{AccessExecutionGraph}}. The {{AccessExecutionGraph}} > contains all the information to derive the {{JobResult}} and additionally the > information needed for serving information about completed jobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)