[
https://issues.apache.org/jira/browse/FLINK-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337705#comment-16337705
]
ASF GitHub Bot commented on FLINK-8450:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5309#discussion_r163570275
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java
---
@@ -199,12 +212,17 @@ public void testCacheEntryCleanup() throws Exception {
public void testConcurrentAccess() throws Exception {
final Time timeout = Time.milliseconds(100L);
final Time timeToLive = Time.hours(1L);
- final JobID jobId = new JobID();
-
- final AccessExecutionGraph accessExecutionGraph =
mock(AccessExecutionGraph.class);
- final JobManagerGateway jobManagerGateway =
mock(JobManagerGateway.class);
- when(jobManagerGateway.requestJob(eq(jobId),
any(Time.class))).thenReturn(CompletableFuture.completedFuture(accessExecutionGraph));
+ final AtomicInteger requestJobCalls = new AtomicInteger(0);
--- End diff --
Wouldn't it be easier to make `CountingRestfulGateway` thread safe, and
reuse it here?
> Make JobMaster/DispatcherGateway#requestJob type safe
> -----------------------------------------------------
>
> Key: FLINK-8450
> URL: https://issues.apache.org/jira/browse/FLINK-8450
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Currently, the {{RestfulGateway#requestJob}} returns a
> {{CompletableFuture<AccessExecutionGraph>}}. Since {{AccessExecutionGraph}}
> is non serializable it could fail if we execute this RPC from a remote
> system. In order to make it typesafe we should change its signature to
> {{SerializableExecutionGraph}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
