Github user lishim commented on a diff in the pull request:
https://github.com/apache/flink/pull/5346#discussion_r163596501
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -365,6 +386,31 @@ public String call(String s) {
}
}
+ public static List<Protos.Parameter>
buildDockerParameters(Option<String> dockerParameters) {
+ if (dockerParameters.isEmpty()) {
+ return Collections.emptyList();
+ } else {
+ String[] dockerParameterSpecifications =
dockerParameters.get().split(",");
+
+ List<Protos.Parameter> parameters = new
ArrayList<>(dockerParameterSpecifications.length);
+
+ for (String dockerParameterSpecification :
dockerParameterSpecifications) {
+ if
(!dockerParameterSpecification.trim().isEmpty()) {
+ String[] match =
dockerParameterSpecification.split("=", 2);
--- End diff --
Some Docker parameters are key=value pairs themselves, so key2=val1=val3 is
actually valid specification. I added a comment to clarify this, and included
a test case.
---
