[
https://issues.apache.org/jira/browse/FLINK-8504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339175#comment-16339175
]
ASF GitHub Bot commented on FLINK-8504:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5361
[FLINK-8504] [flip6] Deregister jobs from the JobLeaderService when no
more slots allocated
## What is the purpose of the change
Let the TaskExecutor deregister jobs from the JobLeaderService once it has
no more slots
for this job allocated.
## Brief change log
- Retrieve first `JobID` before freeing slot
## Verifying this change
- Added `TaskExecutorTest#testRemoveJobFromJobLeaderService`
- Tested manually
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
deregisterJobsFromJobLeaderService
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5361
----
commit 47e03fad38525070e7ae1d2b706301e6c70052bc
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-25T11:01:09Z
[hotfix] Rearrange TaskExecutor imports
commit 31d85a9b81311a44c1f8e09ae616463cca2fe6c7
Author: Till Rohrmann <trohrmann@...>
Date: 2018-01-25T12:50:43Z
[FLINK-8504] [flip6] Deregister jobs from the JobLeaderService when no more
slots allocated
Let the TaskExecutor deregister jobs from the JobLeaderService once it has
no more slots
for this job allocated.
----
> TaskExecutor does not properly deregisters JobManager from JobLeaderService
> ---------------------------------------------------------------------------
>
> Key: FLINK-8504
> URL: https://issues.apache.org/jira/browse/FLINK-8504
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Critical
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{TaskExecutor}} should deregister jobs from the {{JobLeaderService}}
> once it no longer holds slots for this job. The problem is that before
> unregistering the job from the {{JobLeaderService}} in
> {{TaskExecutor#freeInternal}}, the actual slot is freed which also removes
> the {{JobID}} from the slot. Therefore, we lose the information to which job
> the slot belonged. An easy solution would be to return a {{SlotInformation}}
> object instead of the {{TaskSlot}} from {{TaskSlotTable#freeSlot}} which
> contains the respective information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
