Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5230#discussion_r163932401
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java
---
@@ -64,11 +70,18 @@ public int getVersion() {
public void write(DataOutputView out) throws IOException {
super.write(out);
- out.writeShort(stateMetaInfoSnapshots.size());
- for (RegisteredOperatorBackendStateMetaInfo.Snapshot<?> kvState
: stateMetaInfoSnapshots) {
+ out.writeShort(operatorStateMetaInfoSnapshots.size());
+ for (RegisteredOperatorBackendStateMetaInfo.Snapshot<?> kvState
: operatorStateMetaInfoSnapshots) {
+ OperatorBackendStateMetaInfoSnapshotReaderWriters
+
.getOperatorStateWriterForVersion(VERSION, kvState)
+ .writeOperatorStateMetaInfo(out);
+ }
+
+ out.writeShort(broadcastStateMetaInfoSnapshots.size());
+ for (RegisteredBroadcastBackendStateMetaInfo.Snapshot<?, ?>
kvState : broadcastStateMetaInfoSnapshots) {
--- End diff --
same here: the naming of the `kvState` variable here is actually a bit odd
---
