[
https://issues.apache.org/jira/browse/FLINK-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340747#comment-16340747
]
ASF GitHub Bot commented on FLINK-8407:
---------------------------------------
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5369
[FLINK-8407] [DataStream] Setting the parallelism after a partitionin…
## What is the purpose of the change
This PR forbids the users to set parallelism after a partitioning operation
(e.g., broadcast, rescale).
## Brief change log
Removes the overridden method for `setConnectionType` in
`SingleOutputStreamOperator.java`.
## Verifying this change
This change can be verified by the added test
`testParallelismFailAfterPartitioning` in `DataStreamTest.scala`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xccui/flink FLINK-8407
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5369.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5369
----
commit eb725c745ff24442c5f606402c822c517d36a743
Author: Xingcan Cui <xingcanc@...>
Date: 2018-01-26T02:28:58Z
[Flink-8407] [DataStream] Setting the parallelism after a partitioning
operation should be forbidden
----
> Setting the parallelism after a partitioning operation should be forbidden
> --------------------------------------------------------------------------
>
> Key: FLINK-8407
> URL: https://issues.apache.org/jira/browse/FLINK-8407
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
> Reporter: Xingcan Cui
> Assignee: Xingcan Cui
> Priority: Major
>
> Partitioning operations ({{shuffle}}, {{rescale}}, etc.) for a {{DataStream}}
> create new {{DataStreams}}, which allow the users to set parallelisms for
> them. However, the {{PartitionTransformations}} in these returned
> {{DataStreams}} will only add virtual nodes, whose parallelisms could not be
> specified, in the execution graph. We should forbid users to set the
> parallelism after a partitioning operation since they won't actually work.
> Also the corresponding documents should be updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
