Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4979#discussion_r164086981
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
@@ -138,7 +138,9 @@ protected ConnectionFactory setupConnectionFactory()
throws Exception {
* defining custom queue parameters)
*/
protected void setupQueue() throws IOException {
- channel.queueDeclare(queueName, true, false, false, null);
+ if (rmqConnectionConfig.isQueueDeclaration()) {
--- End diff --
I think @GJL's comment is quite valid.
It would also mean that the change in this PR is not required for the
functionality you want.
Do you agree, @sihuazhou? If yes, we can probably close this PR, and the
corresponding JIRA.
---
