[ 
https://issues.apache.org/jira/browse/FLINK-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342072#comment-16342072
 ] 

Christophe Jolif commented on FLINK-8101:
-----------------------------------------

Yes Flavio, the very good news, is that considering the two PRs, I suspect this 
is something people are eagerly waiting for and so should get some attention 
from committers ;)

For your two points:
 # Yes, I hesitated on that one as well. I was not sure what practice would be 
for Flink code base so I tried to fit into what was there and keep the public 
interfaces / abstract classes without splitting into a different API for REST 
based connectors. Actually all the BulkProcessor things can be kept identical 
as now BulkProcessor in Rest client compatible so they way I did it allowed to 
re-use all that code.
 # Elasticsearch documentation is not very clear to be honest, but I suspect 
all of this is sent as JSON (compressed) and I don't think we can do better? 
But maybe you have more references than I do? All I know of is: 
[https://www.elastic.co/blog/benchmarking-rest-client-transport-client] that 
shows the performance vs TransportClient is not ridiculous (except maybe for 
search but that's not our use-case here).

> Elasticsearch 6.x support
> -------------------------
>
>                 Key: FLINK-8101
>                 URL: https://issues.apache.org/jira/browse/FLINK-8101
>             Project: Flink
>          Issue Type: New Feature
>          Components: ElasticSearch Connector
>    Affects Versions: 1.4.0
>            Reporter: Hai Zhou UTC+8
>            Assignee: Flavio Pompermaier
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Recently, elasticsearch 6.0.0 was released: 
> https://www.elastic.co/blog/elasticsearch-6-0-0-released  
> The minimum version of ES6 compatible Elasticsearch Java Client is 5.6.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to