[ 
https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343193#comment-16343193
 ] 

ASF GitHub Bot commented on FLINK-8494:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5377

    [FLINK-8494][config] Migrate CC#DEFAULT_PARALLELISM_KEY

    ## What is the purpose of the change
    
    This PR migrates `ConfigOptions#DEFAULT_PARALLELLISM_KEY` to a 
`ConfigOption`.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8494

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5377
    
----
commit 65885519a691d06b338215a241d5dff0c76df469
Author: zentol <chesnay@...>
Date:   2018-01-23T14:07:09Z

    [FLINK-8494][config] Migrate CC#DEFAULT_PARALLELISM_KEY

----


> Migrate CC#DEFAULT_PARALLELISM_KEY
> ----------------------------------
>
>                 Key: FLINK-8494
>                 URL: https://issues.apache.org/jira/browse/FLINK-8494
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Configuration
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_PARALLELISM_KEY}} was only partialy migrated to a 
> ConfigOption in FLINK-4770.
> A ConfigOption was createde but the usages weren't replaced. The option is 
> also called {{DEFAULT_PARALLELISM_KEY}} when it should be called 
> {{DEFAULT_PARALLELISM}} to be consistent with all other config options.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to