[GitHub] flink pull request #:

[zentol]

Github user zentol commented on the pull request:

    
https://github.com/apache/flink/commit/547d19f9196512231661f427f3792f2e1f831339#commitcomment-27178914
  
    In 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/TestableKinesisDataFetcher.java:
    In 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/TestableKinesisDataFetcher.java
 on line 107:
    shouldn't we trigger this after `super.discoverNewShardstoSubscribe()`?
    
    As in
    ```
    List<StreamShardHandle> newShards = super.discoverNewShardsToSubscribe();
    initialDiscoveryWaiter.trigger();
    return newShards;
    ```
    ```



---