[
https://issues.apache.org/jira/browse/FLINK-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343382#comment-16343382
]
ASF GitHub Bot commented on FLINK-8505:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5354#discussion_r164434005
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -388,6 +378,8 @@ public boolean unregisterTaskManager(InstanceID
instanceId) {
public boolean reportSlotStatus(InstanceID instanceId, SlotReport
slotReport) {
checkInit();
+ LOG.info("Received slot report from instance " + instanceId +
'.');
--- End diff --
nit: I don't see a reason not to use slf4j placeholders here.
> SlotManager can reach inconsistent state
> ----------------------------------------
>
> Key: FLINK-8505
> URL: https://issues.apache.org/jira/browse/FLINK-8505
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{SlotManager}} can reach an inconsistent state when a formerly free task
> slot is reported as allocated by an incoming {{SlotReport}}. The problem is
> that the slot won't be removed from the set of free slots and, thus, will be
> considered for future slot requests.
> The solution is to remove the slot from the set of free slots once it is
> reported allocated.
>
> https://travis-ci.org/tillrohrmann/flink/jobs/332871241
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
