[
https://issues.apache.org/jira/browse/FLINK-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343532#comment-16343532
]
ASF GitHub Bot commented on FLINK-7095:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5375#discussion_r164473535
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -213,10 +226,11 @@ public static void main(String[] args) throws
Exception {
LOG.info("Cannot determine the maximum number of open
file descriptors");
}
- ParameterTool parameterTool = ParameterTool.fromArgs(args);
-
- final String configDir = parameterTool.get("configDir");
+ // try to parse the command line arguments
+ CommandLineParser parser = new DefaultParser();
+ CommandLine cmd = parser.parse(ALL_OPTIONS, args);
+ final String configDir = cmd.getOptionValue("configDir");
--- End diff --
Have you tried whether this actually works? It looks to me as if this will
always return `null`. Please write a test for it.
> Add proper command line parsing tool to TaskManagerRunner.main
> --------------------------------------------------------------
>
> Key: FLINK-7095
> URL: https://issues.apache.org/jira/browse/FLINK-7095
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Till Rohrmann
> Priority: Minor
> Labels: flip-6
>
> We need to add a proper command line parsing tool to the entry point of the
> {{TaskManagerRunner#main}}. At the moment, we are simply using the
> {{ParameterTool}} as a temporary solution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
