[
https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345905#comment-16345905
]
ASF GitHub Bot commented on FLINK-8357:
---------------------------------------
Github user XuMingmin commented on a diff in the pull request:
https://github.com/apache/flink/pull/5371#discussion_r164895415
--- Diff: flink-dist/src/main/flink-bin/conf/log4j-cli.properties ---
@@ -19,10 +19,11 @@
log4j.rootLogger=INFO, file
# Log all infos in the given file
-log4j.appender.file=org.apache.log4j.FileAppender
+log4j.appender.file=org.apache.log4j.DailyRollingFileAppender
log4j.appender.file.file=${log.file}
log4j.appender.file.append=false
log4j.appender.file.layout=org.apache.log4j.PatternLayout
+log4j.appender.file.DatePattern=.yyyy-MM-dd
--- End diff --
add `log4j.appender.file.MaxFileSize` and
`log4j.appender.file.MaxBackupIndex` to limit the total size of log files.
> enable rolling in default log settings
> --------------------------------------
>
> Key: FLINK-8357
> URL: https://issues.apache.org/jira/browse/FLINK-8357
> Project: Flink
> Issue Type: Improvement
> Components: Logging
> Reporter: Xu Mingmin
> Assignee: mingleizhang
> Priority: Major
> Fix For: 1.5.0
>
>
> The release packages uses {{org.apache.log4j.FileAppender}} for log4j and
> {{ch.qos.logback.core.FileAppender}} for logback, which could results in very
> large log files.
> For most cases, if not all, we need to enable rotation in a production
> cluster, and I suppose it's a good idea to make rotation as default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
