Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r165102741
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java
---
@@ -325,8 +325,7 @@ public OperatorStateHandle performOperation() throws
Exception {
return task;
}
- @Override
- public void restore(Collection<OperatorStateHandle> restoreSnapshots)
throws Exception {
+ public void restore(StateObjectCollection<OperatorStateHandle>
restoreSnapshots) throws Exception {
--- End diff --
Because there where a couple of static helper methods operating on those
collections, e.g. disposing a collection of state handles or checking if the
collection as a whole has any state. IMO those things should go to a separate
class and not be static helpers over a generic collection.
---
