Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5371#discussion_r165244013
--- Diff: flink-dist/src/main/flink-bin/conf/logback-yarn.xml ---
@@ -17,8 +17,14 @@
-->
<configuration>
- <appender name="file" class="ch.qos.logback.core.FileAppender">
+ <appender name="file"
class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>${log.file}</file>
+ <rollingPolicy
class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
+ <!-- daily rollover -->
+
<fileNamePattern>logFile.%d{yyyy-MM-dd}.log</fileNamePattern>
--- End diff --
Yea. It should be.
---
