[
https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612090#comment-14612090
]
ASF GitHub Bot commented on FLINK-2311:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118072783
I think the statistics collection pull request has been created before we
splitted the `flink-contrib` project into individual submodules.
Now contrib is much more fine grained, with the dependencies.
Afaik it should be impossible to have a "pom"-type maven module which also
contains code?!
The quickstart's pom is setting the dependencies for the user correctly.
Are the dependencies of "flink-contrib" overwriting the "provided" scope from
the quickstart-generated poms?
In my understanding, building a quickstart generated project with -P
build-jar profile should create the optimal fat jar, containing exactly the
classes needed.
> Set flink-* dependencies in flink-contrib as "provided"
> -------------------------------------------------------
>
> Key: FLINK-2311
> URL: https://issues.apache.org/jira/browse/FLINK-2311
> Project: Flink
> Issue Type: Improvement
> Components: flink-contrib
> Affects Versions: 0.10, 0.9.1
> Reporter: Alexander Alexandrov
> Assignee: Alexander Alexandrov
> Priority: Minor
> Labels: easyfix, maven, patch
> Fix For: 0.10, 0.9.1
>
>
> The {{flink-contrib}} folder is assumed to be provided by the user. As such,
> other {{flink-*}} dependencies referenced within {{flink-contrib}} should be
> set as _'provided'_ in order to keep the size of the user jars down. I'm
> currently testing a patch that changes the poms as suggested and will open a
> PR on GitHub if this everything passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
