Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r165321013
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/TestTaskStateManager.java
---
@@ -67,8 +69,11 @@ public TestTaskStateManager(
this.jobId = jobId;
this.executionAttemptID = executionAttemptID;
this.checkpointResponder = checkpointResponder;
- this.taskStateSnapshotsByCheckpointId = new HashMap<>();
+ this.jobManagerTaskStateSnapshotsByCheckpointId = new
HashMap<>();
+ this.taskManagerTaskStateSnapshotsByCheckpointId = new
HashMap<>();
this.reportedCheckpointId = -1L;
+ this.subtaskLocalStateBaseDirectory =
+ new File(System.getProperty("java.io.tmpdir"),
"testLocalState_" + UUID.randomUUID());
--- End diff --
Shouldn't this come from something like a `TemporaryFolder` such that the
directory get's cleaned up in all cases. Consequently, maybe we should pass in
the `subtaskLocalStateBaseDirectory` from the test using this class.
---
