[
https://issues.apache.org/jira/browse/FLINK-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348713#comment-16348713
]
ASF GitHub Bot commented on FLINK-8472:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5364#discussion_r165385564
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/keyed/KeyedJob.java
---
@@ -100,9 +100,7 @@ public static void main(String[] args) throws Exception
{
.map(new StatefulStringStoringMap(mode, "first"))
.setParallelism(4);
- if (mode == ExecutionMode.MIGRATE || mode ==
ExecutionMode.RESTORE) {
--- End diff --
@zentol can you confirm whether these changes make sense?
From the discussions I see in https://github.com/apache/flink/pull/3844, I
assume this was a leftover to write a 1.2 savepoint (when uids couldn't be
added for each chained operator separately). So it should be ok to remove this?
> Extend migration tests for Flink 1.4
> ------------------------------------
>
> Key: FLINK-8472
> URL: https://issues.apache.org/jira/browse/FLINK-8472
> Project: Flink
> Issue Type: Test
> Components: Tests
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Blocker
> Fix For: 1.5.0, 1.4.1
>
>
> The following migration tests should be extended to cover migrating Flink
> jobs with a 1.4 savepoint.
> * {{WindowOperatorMigrationTest}}
> * {{CEPMigrationTest}}
> * {{StatefulJobSavepointMigrationTestITCase}}
> * {{FlinkKinesisConsumerMigrationTest}}
> * {{FlinkKafkaConsumerBaseMigrationTest}}
> * {{ContinuousFileProcessingMigrationTest}}
> * {{BucketingSinkMigrationTest}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
