[
https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348765#comment-16348765
]
ASF GitHub Bot commented on FLINK-8345:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5230#discussion_r165385868
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java
---
@@ -148,21 +170,27 @@ public void close() throws IOException {
@Override
public void dispose() {
IOUtils.closeQuietly(closeStreamOnCancelRegistry);
- registeredStates.clear();
+ registeredOperatorStates.clear();
+ registeredBroadcastStates.clear();
}
//
-------------------------------------------------------------------------------------------
// State access methods
//
-------------------------------------------------------------------------------------------
+ @Override
+ public <K, V> ReadWriteBroadcastState<K, V>
getBroadcastState(MapStateDescriptor<K, V> stateDescriptor) throws Exception {
--- End diff --
I think we don't need this because the other `getBroadcastState()` is only
ever called with `BROADCAST` mode.
> Iterate over keyed state on broadcast side of connect with broadcast.
> ---------------------------------------------------------------------
>
> Key: FLINK-8345
> URL: https://issues.apache.org/jira/browse/FLINK-8345
> Project: Flink
> Issue Type: New Feature
> Components: Streaming
> Affects Versions: 1.5.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
