Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5393#discussion_r165587359
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
 ---
    @@ -182,13 +191,15 @@ public KinesisDataFetcher(List<String> streams,
                                                        
SourceFunction.SourceContext<T> sourceContext,
                                                        RuntimeContext 
runtimeContext,
                                                        Properties configProps,
    -                                                   
KinesisDeserializationSchema<T> deserializationSchema) {
    +                                                   
KinesisDeserializationSchema<T> deserializationSchema,
    +                                                   KinesisShardAssigner 
kinesisShardToSubTaskIndexFn) {
    --- End diff --
    
    mismatching variable name: `kinesisShardToSubTaskIndexFn` --> 
`kinesisShardAssigner` or just `shardAssigner`


---

Reply via email to