[ 
https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350038#comment-16350038
 ] 

ASF GitHub Bot commented on FLINK-8516:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5393#discussion_r165586994
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
 ---
    @@ -214,6 +226,7 @@ protected KinesisDataFetcher(List<String> streams,
                this.totalNumberOfConsumerSubtasks = 
runtimeContext.getNumberOfParallelSubtasks();
                this.indexOfThisConsumerSubtask = 
runtimeContext.getIndexOfThisSubtask();
                this.deserializationSchema = 
checkNotNull(deserializationSchema);
    +           this.shardAssigner = checkNotNull(shardAssigner);
    --- End diff --
    
    We also need to try cleaning the closure of the given object (if it is a 
non-static inner class):
    ```
    ClosureCleaner.clean(shardAssigner, true);
    ```


> FlinkKinesisConsumer does not balance shards over subtasks
> ----------------------------------------------------------
>
>                 Key: FLINK-8516
>                 URL: https://issues.apache.org/jira/browse/FLINK-8516
>             Project: Flink
>          Issue Type: Bug
>          Components: Kinesis Connector
>    Affects Versions: 1.4.0, 1.3.2, 1.5.0
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Major
>
> The hash code of the shard is used to distribute discovered shards over 
> subtasks round robin. This works as long as shard identifiers are sequential. 
> After shards are rebalanced in Kinesis, that may no longer be the case and 
> the distribution become skewed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to