[ 
https://issues.apache.org/jira/browse/FLINK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350209#comment-16350209
 ] 

ASF GitHub Bot commented on FLINK-8549:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5402
  
    Thanks for the heads up - nice to know that the generator also supports 
different projects now.
    
    I am still leaning towards making this change, because all other shutdown 
options are already in the `TaskManagerOptions`, and this class just felt out 
of place in `flink-streaming-java`.


> Move TimerServiceOptions to TaskManagerOptions
> ----------------------------------------------
>
>                 Key: FLINK-8549
>                 URL: https://issues.apache.org/jira/browse/FLINK-8549
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Major
>             Fix For: 1.5.0
>
>
> The {{TimerServiceOptions}} are in the wrong place (prohibit generation of 
> config docs) and cause over-fragmentation of the options in the code base.
> I propose to simple move the one option from that class to the 
> {{TaskManagerOptions}}, as it relates to task execution. Other shutdown 
> related options are in there already.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to