[ 
https://issues.apache.org/jira/browse/FLINK-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351667#comment-16351667
 ] 

ASF GitHub Bot commented on FLINK-7856:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5397#discussion_r165835719
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ---
    @@ -305,6 +311,84 @@ public void postStop() throws Exception {
        //  RPC methods
        // 
======================================================================
     
    +   @Override
    +   public CompletableFuture<StackTraceSampleResponse> 
requestStackTraceSample(
    +                   final ExecutionAttemptID executionAttemptId,
    +                   final int sampleId,
    +                   final int numSamples,
    +                   final Time delayBetweenSamples,
    +                   final int maxStackTraceDepth,
    +                   final Time timeout) {
    +           return requestStackTraceSample(
    +                   executionAttemptId,
    +                   sampleId,
    +                   numSamples,
    +                   delayBetweenSamples,
    +                   maxStackTraceDepth,
    +                   new ArrayList<>(numSamples),
    +                   new CompletableFuture<>());
    +   }
    +
    +   private CompletableFuture<StackTraceSampleResponse> 
requestStackTraceSample(
    +                   final ExecutionAttemptID executionAttemptId,
    +                   final int sampleId,
    +                   final int numSamples,
    +                   final Time delayBetweenSamples,
    +                   final int maxStackTraceDepth,
    +                   final List<StackTraceElement[]> currentTraces,
    +                   final CompletableFuture<StackTraceSampleResponse> 
resultFuture) {
    +
    +           if (numSamples > 0) {
    +                   getRpcService().getScheduledExecutor().schedule(() -> 
runAsync(() -> {
    +                           final Optional<StackTraceElement[]> stackTrace 
= getStackTrace(executionAttemptId, maxStackTraceDepth);
    --- End diff --
    
    Fixed.


> Port JobVertexBackPressureHandler to REST endpoint
> --------------------------------------------------
>
>                 Key: FLINK-7856
>                 URL: https://issues.apache.org/jira/browse/FLINK-7856
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, REST, Webfrontend
>            Reporter: Fang Yong
>            Assignee: Gary Yao
>            Priority: Major
>
> Port JobVertexBackPressureHandler to REST endpoint



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to